Fix/dirty rect#1159
Open
100pah wants to merge 8 commits into
Open
Conversation
9 tasks
…places were missed.
…ION_PROPS_NONE) to allow stopping animations on specific props only, providing more fine-grained control than `el.stopAnimation`. 2. Unify the behaviors of `el.animateTo`/`el.animateFrom` callbacks (`done`, `aborted` and `during`). Comprehensive test cases are added. 2.1. Add the call to `during(1)` before the call to `done` when no animator is added in the call of `el.animateTo`/`el.animateFrom`. 2.2. Fix `during` failing to be called after `animators[0]` is removed by a subsequent `el.animateTo`/`el.animateFrom`. 2.3. Support an option `cleanCb` to discard previous callbacks, by which a pattern is enabled: align the lifetime of callbacks to per call to `el.animateTo`/`el.animateFrom`, otherwise, residual callbacks may cause unexpected behaviors. 2.4. Clarify the usage of `force`. 3. Support `duration: 0`; previously a `NaN` was assign to props. 4. Fix rounding error in animation interpolation; previously target value may not be reached in some cases. 5. Add comprehensive test cases for Element Animation APIs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix dirty rect
Broken by v6.1.0.
Enhance Element Animation
animationProps(accepting a sentinel value ELEMENT_ANIMATION_PROPS_NONE) to allow stopping animations on specific props only, providing more fine-grained control thanel.stopAnimation.el.animateTo/el.animateFromcallbacks (done,abortedandduring). Comprehensive test cases are added.2.1. Add the call to
during(1)before the call todonewhen no animator is added in the call ofel.animateTo/el.animateFrom.2.2. Fix
duringfailing to be called afteranimators[0]is removed by a subsequentel.animateTo/el.animateFrom.2.3. Support an option
cleanCbto discard previous callbacks, by which a pattern is enabled: align the lifetime of callbacks to per call toel.animateTo/el.animateFrom, otherwise, residual callbacks may cause unexpected behaviors.2.4. Clarify the usage of
force.duration: 0; previously aNaNwas assign to props.Platform
Unify all timer to
platformApi.getTime()- previously some places were missed.Test Utilities
Upgrade unit test infrastructure.